Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(module:select): fix select tag option display #3574

Merged
merged 1 commit into from
Jun 14, 2019
Merged

fix(module:select): fix select tag option display #3574

merged 1 commit into from
Jun 14, 2019

Conversation

vthinkxie
Copy link
Member

close #3424 close #3563

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented Jun 14, 2019 •
edited
Loading

Codecov Report

Merging #3574 into 7.5.x will decrease coverage by 0.01%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff            @@
##            7.5.x   #3574      +/-   ##
=========================================
- Coverage   95.72%   95.7%   -0.02%     
=========================================
  Files         690     690              
  Lines       13701   13698       -3     
  Branches     1826    1823       -3     
=========================================
- Hits        13115   13110       -5     
- Misses        198     199       +1     
- Partials      388     389       +1
Impacted Files Coverage Δ
components/select/nz-select.service.ts 85.71% <80%> (-1.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bb84fe...15efca1. Read the comment docs.

@vthinkxie vthinkxie merged commit d93fb66 into NG-ZORRO:7.5.x Jun 14, 2019
@wenqi73 wenqi73 mentioned this pull request Jun 14, 2019
Closed
3 tasks
@weekly-digest weekly-digest bot mentioned this pull request Jun 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vthinkxie